Add ESP32S3 - Githubissues

esp-rs / esp-flasher-stub

Rust implementation of flasher stub located in esptool

Apache License 2.0

17 stars 10 forks source link

Add ESP32S3 #7

Closed JurajSadel closed 1 year ago

JurajSadel commented 1 year ago

This PR is built on top of https://github.com/esp-rs/esp-flasher-stub/pull/3 so technically adds support for ESP32 and ESP32S3. Contains also an initial cleanup and refactor. Updates esp-hal versions.

bjoernQ commented 1 year ago

general things not for this PR but for later

is there still something missing in the HALs UART driver implementation? If yes, we should change that so we don't need to do the raw register access here
maybe instead of the dprint module it should use the log crate

JurajSadel commented 1 year ago

@bjoernQ @igrr @MabezDev thank you for doing review, I pushed second round of cleanup.

FYI @DNedic, @dobairoland, @radimkarnis