New package releases - Githubissues

jessebraham commented 1 month ago

Update both packages to use latest versions of esp-hal and other dev dependencies
Update MSRVs to match that of esp-hal
Add instructions to the README.md files demonstrating how to build and run the examples
Make .cargo/config.toml files consistent between packages

Looks like we forgot to publish the initial version of esp-hal-buzzer when it was added, oops. Once this PR is merged I will publish both packages.

Closes #7

jessebraham commented 1 month ago

@tschundler would you mind reviewing the additions to the README.md files please? Have I included adequate information to get you up and running? Happy to make any additional changes if not!

jessebraham commented 1 month ago

Ahh I missed #6, let's get that in first :)

AnthonyGrondin commented 1 month ago

LGTM

I patched one of my projects to use this branch and everything works fine.

tschundler commented 1 month ago

@tschundler would you mind reviewing the additions to the README.md files please? Have I included adequate information to get you up and running? Happy to make any additional changes if not!

LGTM - just tried it out and and used it to double check a timing-related PR I'm about to send, thanks.

jamessizeland commented 1 month ago

what is left to complete this PR please? I'd like to use it with esp-hal 21.1

jessebraham commented 1 month ago

what is left to complete this PR please? I'd like to use it with esp-hal 21.1

Just wanted to get #6 merged, have not had a chance to look at it yet unfortunately due to other obligations. If somebody from the community can review/test that it would speed things up.

Sorry for the delays, will do my best to get releases out this week.

horho77 commented 1 month ago

what is left to complete this PR please? I'd like to use it with esp-hal 21.1

Just wanted to get #6 merged, have not had a chance to look at it yet unfortunately due to other obligations. If somebody from the community can review/test that it would speed things up.

Sorry for the delays, will do my best to get releases out this week.

I did have a look at https://github.com/esp-rs/esp-hal-community/pull/6 and it looks good. I think an added example as mentioned in the comments would be a good idea. Sorry to barge in... I have an internal fork of the hal-esp-smartled (from an older version of esp-hal) with added support for RGBW LEDs. I was hoping to submit a PR here at some point.

My question just echoes the comment above:

what is left to complete this PR please? I'd like to use it with esp-hal 21.1

https://github.com/esp-rs/esp-hal-community/pull/6 seems to be adding a new functionality. Is that something that's needed for this PR?

okhsunrog commented 1 month ago

@AnthonyGrondin Can this be merged? Both latest release and the main branch can't be used with the latest esp-hal

AnthonyGrondin commented 1 month ago

As far as I'm aware, this PR is waiting for #6 to get merged first.

I'd like to get #11 merged before cutting a new release of esp-hal-buzzer. Well, before publishing, since it has never been published.

esp-rs / esp-hal-community

New package releases #8