Remove uneccessary bitfield from I2C driver

esp-rs / esp-hal

no_std Hardware Abstraction Layers for ESP32 microcontrollers

https://docs.esp-rs.org/esp-hal/

Apache License 2.0

678 stars 189 forks source link

Closed jessebraham closed 4 weeks ago

jessebraham commented 2 months ago

Not sure why we merged this when patching the PAC would have been trivial, but our I2C driver currently contains a bitfield definition for the command registers:
https://github.com/esp-rs/esp-hal/blob/c4ad9d37ab11a740fdd7f18d48b89f6fd59f90f4/esp-hal/src/i2c.rs#L133-L184

The PACs should be patched and this should be removed.

playfulFence commented 1 month ago

As soon as https://github.com/esp-rs/esp-pacs/pull/259 is resolved, I'll do the patch for the PAC