Closed bjoernQ closed 1 month ago
Ok makes sense the test didn't catch this since it's only broken for async (which doesn't make a lot of sense somehow)
I guess I found it: https://github.com/esp-rs/esp-hal/blob/bc7c53f6680dc194262a451e3c9bf71c2730c9a5/esp-hal/src/dma/mod.rs#L1455
That should be CH::Tx::waker()
Whoops! sorry about that 😬
Whoops! sorry about that 😬
No problem - should have noticed it during the review 😃
Apparently i2s-write is broken - luckily released 0.19.0 is not affected
Easy to reproduce via
cargo xtask run-example examples esp32c6 embassy_i2s_sound
- after that commit it doesn't do anything anymoreThis is especially bad since the hil-test didn't catch this 😢