SHA is waaaaay too easy to misuse

esp-rs / esp-hal

no_std Hardware Abstraction Layers for ESP32 microcontrollers

https://docs.esp-rs.org/esp-hal/

Apache License 2.0

704 stars 195 forks source link

Closed bugadani closed 1 week ago

bugadani commented 2 weeks ago

Creating multiple peripheral drivers is trivial and at each time it resets the peripheral (https://github.com/esp-rs/esp-hal/blob/v0.20.0/esp-hal/src/sha.rs#L427-L444). This makes the driver a gigantic footgun when used in multiple contexts
We're accessing the peripheral in process_buffer in a racy way

Dominaezzz commented 2 weeks ago

Depending on how quickly you want this fixed, I'm interested in taking care of this.

I can keep to the 0.21.0 deadline and throw this in as well.