search

esp-rs / esp-hal

no_std Hardware Abstraction Layers for ESP32 microcontrollers
https://docs.esp-rs.org/esp-hal/
Apache License 2.0
762 stars 212 forks source link

Make `asynch` modules private #2319

Open MabezDev opened 1 month ago

MabezDev commented 1 month ago

Some drivers have this module public, some don't. Imo now async is enabled by default, we should make these modules private and reexport the relevant public bits.

bugadani commented 1 month ago

We don't even need these modules for anything, really.

MabezDev commented 1 month ago

We don't even need these modules for anything, really.

Yep, also just removing them could be fine too.

bugadani commented 1 month ago

Just... please wait a bit before starting this, I'd like to avoid massive merge conflicts with some of my unpublished branches 🥺

MabezDev commented 1 month ago

No rush, just making a point of it in the this issue so it gets done at some point :).