Separate out PHY initialization.

Frostie314159 commented 1 week ago

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request. To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

[ ] I have updated existing examples or added new ones (if applicable).
[ ] I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
[ ] My changes were added to the CHANGELOG.md in the proper section.
[ ] I have added necessary changes to user code to the Migration Guide.
[ ] My changes are in accordance to the esp-rs API guidelines

Extra:

[x] I have read the CONTRIBUTING.md guide and followed its instructions.

Pull Request Details 📖

Description

This PR aims to provide a unified way of initializing the PHY. So far, only radio clock handling has been overhauled.

Testing

Frostie314159 commented 1 week ago

So far, I have only partially implemented shared radio clock control. I haven't updated esp-wifi yet, since I wasn't sure if this design is ok for everyone, so feedback is welcome.

bugadani commented 1 week ago

Besides a couple of stylistic nitpicks I'll not list, I think the direction here is all right, although I don't see how upcoming work may change things around this.

Frostie314159 commented 1 week ago

Ok! Glad to hear that. The reason I made the PHY status static is, because next I want to implement splitting the control over the radio clocks for the individual modems, and the PHY still needs to be controlled centrally.

esp-rs / esp-hal