esp-rs / esp-hal

no_std Hardware Abstraction Layers for ESP32 microcontrollers
https://docs.esp-rs.org/esp-hal/
Apache License 2.0
764 stars 214 forks source link

[2/3] Timer refactor: TIMG #2581

Closed MabezDev closed 1 hour ago

MabezDev commented 1 day ago

We appreciate the time and effort you've put into this pull request. To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

Extra:

Pull Request Details 📖

Description

Part 2 which simplifies the TIMG timers. All sub timers now have the same type erased type: Timer. I also managed to dedupe and remove the instance trait completely (the instance trait for TIMG still exists), which is a huge code saving.

MabezDev commented 6 hours ago

Skip changelog for the same reasons as part 1