esp-rs / esp-idf-svc

Type-Safe Rust Wrappers for various ESP-IDF services (WiFi, Network, Httpd, Logging, etc.)
https://docs.esp-rs.org/esp-idf-svc/
Apache License 2.0
285 stars 161 forks source link

Fix missing error return #414

Closed owenthewizard closed 2 months ago

owenthewizard commented 2 months ago

This looks like an oversight. Too bad the C bindings aren't #[must_use] :sweat_smile: .

ivmarkov commented 2 months ago

@owenthewizard if you haven't started yet with your casts rework, how about we fix the transmute problem only? Or at least fix it first, as it is the most pressing, as it breaks CI. The other cleanup is nice to have, but not really urgent, I guess.