search

esp-rs / esp-idf-svc

Type-Safe Rust Wrappers for various ESP-IDF services (WiFi, Network, Httpd, Logging, etc.)
https://docs.esp-rs.org/esp-idf-svc/
Apache License 2.0
285 stars 161 forks source link

Fix esp-idf >= v5.3beta #434

Closed Vollbrecht closed 3 weeks ago

Vollbrecht commented 1 month ago

fix #433

Vollbrecht commented 1 month ago

@AlixANNERAUD since you PR'ed the addition i want you just to notify that upstream esp-idf includes new API's if you are interested in the new fields

AlixANNERAUD commented 1 month ago

@AlixANNERAUD since you PR'ed the addition i want you just to notify that upstream esp-idf includes new API's if you are interested in the new fields

Okay, I'm in the exam period but I'll try to do it this week

Vollbrecht commented 1 month ago

@AlixANNERAUD since you PR'ed the addition i want you just to notify that upstream esp-idf includes new API's if you are interested in the new fields

Okay, I'm in the exam period but I'll try to do it this week

Yeah no worries there is no direct action needed, just a headsup for you :D Exams have priority, even if you want to rather work on some code ;)

AlixANNERAUD commented 2 weeks ago

@AlixANNERAUD since you PR'ed the addition i want you just to notify that upstream esp-idf includes new API's if you are interested in the new fields

I just checked, and the differences between esp-idf v5.2 and v5.3 (especially esp_vfs_fat.h, sdmmc_host.h and sdspi_host.h), have little impact on the SD card / VFS aspects (just the refactoring of DMA for sdmmc_host_t and refactoring of mount configuration for VFS), which doesn't seem to affect the user API, although the implementation for DMA seems a bit unclear. In addition, i don't think it's necessary to implement x_get_dma_info either (but I can do it if you want to).

Vollbrecht commented 2 weeks ago

@AlixANNERAUD since you PR'ed the addition i want you just to notify that upstream esp-idf includes new API's if you are interested in the new fields

I just checked, and the differences between esp-idf v5.2 and v5.3 (especially esp_vfs_fat.h, sdmmc_host.h and sdspi_host.h), have little impact on the SD card / VFS aspects (just the refactoring of DMA for sdmmc_host_t and refactoring of mount configuration for VFS), which doesn't seem to affect the user API, although the implementation for DMA seems a bit unclear. In addition, i don't think it's necessary to implement x_get_dma_info either (but I can do it if you want to).

Thanks for the feedback. Its fine i think, if someone needs it he can extend the implementation as needed.