search

esp-rs / esp-idf-template

A "Hello, world!" template of a Rust binary crate for the ESP-IDF framework.
416 stars 50 forks source link

Change defaults prompt to advanced #131

Closed SergioGasquez closed 1 year ago

SergioGasquez commented 1 year ago

See https://github.com/esp-rs/esp-template/issues/89

ivmarkov commented 1 year ago

@MabezDev Since you mention the master failures... the Espressif C folks seemingly removed the UART_NUM_MAX def from the public header of the uart driver. Oddly enough, it is mentioned in the methods' documentation.

Any idea what is going on?

ivmarkov commented 1 year ago

I mean, I can switch the code to use SOC_UART_NUM instead, but it still feels weird...

MabezDev commented 1 year ago

Seems like it was changed from a #define to an enum for the C drivers usage: https://github.com/espressif/esp-idf/blob/67552c31dac8cd94fb0d63192a538f4f984c5b6e/components/hal/include/hal/uart_types.h#L21.

I guess its easiest for us to just use SOC_UART_NUM?