Enable CI for v4.4 - Githubissues

esp-rs / esp-idf-template

A "Hello, world!" template of a Rust binary crate for the ESP-IDF framework.

373 stars 43 forks source link

Enable CI for v4.4 #135

Closed SergioGasquez closed 12 months ago

ivmarkov commented 1 year ago

@SergioGasquez As you can see, this does not work. I no longer remember who has removed it, but restoring the build for V4.4 would require a bit more effort.

ivmarkov commented 1 year ago

Yeah. I now remember - this has regressed when we have introduced the MCUs which are supported in ESP IDF 5.1+ only: esp32c2, esp32p4, esp32c5 and so on.

For 4.4, we have to only run the CI with the MCUs supported by it: esp32, esp32s2/s3, and esp32c3, I think

SergioGasquez commented 1 year ago

Oh yes! That was dumb from my side, I did the changes onto the CI so we have several jobs:

cargo-checks-v5: Checks master and release/v5.1
cargo-checks-v4: Checks release/v4.4
container-check: Builds a v4.4 template project on the container Every step only runs for the supported targets.

ivmarkov commented 12 months ago

Thanks! I'll just merge.