Closed antogilbert closed 8 months ago
Can you please NOT do --all-features
? Or remove the pio
feature if you really insist?
@ivmarkov removing pio
worked. Thanks. However, just for clarity, I have simply generated the repo with the wizard provided by the esp-rs/esp-idf-template, I haven't created the CI files myself or modified anything. Is there a reason why pio
fails the clippy checks?
My suspicion is that it is just a case of case sensitive comparison, where it should be case insensitive. Let me check that quickly...
OK, I've released new patch-level releases of both embuild
and esp-idf-sys
.
Just do cargo update
and the problem would be fixed.
As to why you probably don't want --all-features
- the native
and pio
features are kind of mutually exclusive, as you can either build the ESP IDF using the native CMake
ESP IDF build, or by using PlatformIO
. When you specify --all-features
what happens is that the pio
build will prevail, as it is the non-default option that overrides native
.
pio
based build only supports whatever ESP IDF version is supported by the latest PlatformIO though, and does not have many of the configuration options the native
build has.
Bug description
I created a new cargo project, committed it on github and the clippy checks on CI are failing with the following message:
This happens also if i run the clippy command manually. I tried with these two docker images when running locally: espressif/idf-rust:esp32s3_latest espressif/idf-rust:esp32_latest
To Reproduce
Steps to reproduce the behavior:
docker run --rm -it espressif/idf-rust:esp32s3_latest bash
cargo install cargo-generate
USER=antogilbert cargo generate esp-rs/esp-idf-template
Use these values in the wizard:
cd sensors
cargo clippy --all-targets --all-features --workspace -- -D warnings
Expected behavior
Generated project should not fail clippy checks.
Environment
inside the following two containers:
espressif/idf-rust:esp32s3_latest espressif/idf-rust:esp32_latest