search

esp-rs / esp-idf-template

A "Hello, world!" template of a Rust binary crate for the ESP-IDF framework.
414 stars 50 forks source link

Update to the new release #182

Closed ivmarkov closed 8 months ago

ivmarkov commented 8 months ago

Seems like the MSRV is now 1.75 while in CI we use 1.71

Indeed. Shall we just remove the version string from there? This way it would be always compiled against the latest Rust version available?

SergioGasquez commented 8 months ago

Indeed. Shall we just remove the version string from there? This way it would be always compiled against the latest Rust version available?

Yes, I think that would be better. Regarding https://github.com/esp-rs/esp-idf-template/pull/182/commits/88d0ef74950f6aeca20cfaba1be1faa45aae3956, the tag 1.5 already points to the latest patch release, so I would also recommend using 1.5 instead of the pointing to the latest "full" version

ivmarkov commented 8 months ago

Indeed. Shall we just remove the version string from there? This way it would be always compiled against the latest Rust version available?

Yes, I think that would be better. Regarding 88d0ef7, the tag 1.5 already points to the latest patch release, so I would also recommend using 1.5 instead of the pointing to the latest "full" version

Ok. I just copied from somewhere, but will revert.

ivmarkov commented 8 months ago

Indeed. Shall we just remove the version string from there? This way it would be always compiled against the latest Rust version available?

Yes, I think that would be better. Regarding 88d0ef7, the tag 1.5 already points to the latest patch release, so I would also recommend using 1.5 instead of the pointing to the latest "full" version

Ok. I just copied from somewhere, but will revert.

Reverted. You need to squash prior to merging.

ivmarkov commented 8 months ago

Sorry for the vfs hiccup - did not anticipate that. :) For now, I've enabled the vfs component in the cmake build. Next patch release of esp-idf-svc will have that addressed.