search

esp-rs / esp-idf-template

A "Hello, world!" template of a Rust binary crate for the ESP-IDF framework.
417 stars 50 forks source link

Add CI to build all the targets #35

Closed SergioGasquez closed 2 years ago

SergioGasquez commented 2 years ago

Expanded the CI to build the project for all the targets using the Dockerfile generated for devcontainer support.

SergioGasquez commented 2 years ago

I'm not sure why we are now installing cargo-generate that way?

It's only because it's faster, but I wouldn't mind using cargo install if you think is better

SergioGasquez commented 2 years ago

Installing cargo-generate from release binaries can also make the CI more "consistent" as it avoids some "external" errors on CI. Eg: Todays CI run failed because cargo install cargo-generate was failing

ivmarkov commented 2 years ago

@SergioGasquez Sorry for following up late, can you resolve the conflicts, then I'll merge?

SergioGasquez commented 2 years ago

@SergioGasquez Sorry for following up late, can you resolve the conflicts, then I'll merge?

Hello @ivmarkov, do not worry about the delays! Conflicts are now resolved. Thanks for all your dedication!

ivmarkov commented 2 years ago

@SergioGasquez I think we need to temporarily disable the PlatformIO based build, until we figure out what is wrong there.

SergioGasquez commented 2 years ago

@SergioGasquez I think we need to temporarily disable the PlatformIO based build, until we figure out what is wrong there.

I've commented those steps!

ivmarkov commented 2 years ago

@SergioGasquez BTW it still complains that the branch is unmergeable due to conflicts. I think you need to rebase it on top of latest master first.

SergioGasquez commented 2 years ago

It now shows that it can be merged with no conflicts! :)

ivmarkov commented 2 years ago

It can be merged but it cannot be rebased. Anyway, ill not use rebase then.