search

esp-rs / esp-idf-template

A "Hello, world!" template of a Rust binary crate for the ESP-IDF framework.
373 stars 44 forks source link

Remove anyhow as a build dependency #73

Closed faern closed 1 year ago

faern commented 1 year ago

This is subjective. But I did not feel like the anyhow dependency helped really. A whole dependency just to save a few characters in a single place in build.rs. I personally think that a template should be light weight and easy to understand. Not that anyhow complicated things by a lot, but it also did not reduce complexity. So my suggestion is that we get rid of it and just handle this error with standard Rust.

MabezDev commented 1 year ago

I like this change, we don't really use anyhow anywhere else anymore. Could you fix the CI issues and I'd be happy to merge this :)

MabezDev commented 1 year ago

Oh actually sorry I just realised its the master build that's failing, and its unrelated to this PR. LGTM!