search

esp-rs / esp-idf-template

A "Hello, world!" template of a Rust binary crate for the ESP-IDF framework.
373 stars 44 forks source link

WOKWI PROJECT ID #86

Closed GabrielAlonsoCabral closed 1 year ago

GabrielAlonsoCabral commented 1 year ago

Hey guys, i've started to use esp-idf-template and i enjoy so much. Also, i've notice that inside ./scripts/run-wokwi.sh we must to set WOKWI_PROJECT_ID (hard coded).

Can i open an PR to get dynamically from .env ?

SergioGasquez commented 1 year ago

Hi! This could be a great improvement, and, of course, your PR will be more than welcomed. That being said, we will probably update the template to use Wokwi VS Code extension instead of using the wokwi-server crate. See https://github.com/esp-rs/esp-template/pull/56 for more details.

Vollbrecht commented 1 year ago

should we add conditional option for adding wokwi support independent of an container or not? It should also generate an diagram.json and wokwi.toml. I would like that

SergioGasquez commented 1 year ago

should we add conditional option for adding wokwi support independent of an container or not?

Yes, today I started working on updating the template (https://github.com/SergioGasquez/esp-idf-template/tree/feature/devcontainer-update) and this is something that I would definitely add. I already added it for esp-template today: https://github.com/esp-rs/esp-template/commit/c2f792ffbbfecdddd4ee9da6ad6c6d6c146bad42