search

esp-rs / esp-idf-template

A "Hello, world!" template of a Rust binary crate for the ESP-IDF framework.
417 stars 50 forks source link

Clarify target runner arguments for espflash v1.x.x and v2.x.x #88

Closed dstrmberg closed 1 year ago

dstrmberg commented 1 year ago

Replace 'espflash --monitor' with 'espflash flash --monitor'

dstrmberg commented 1 year ago

Hi, I tested 'cargo run' and it didn't work so I made a small patch to fix it

ivmarkov commented 1 year ago

This was discussed the other day. One command is for espflash V1, and the other - for V2 which is not yet released. Which one do you use?

dstrmberg commented 1 year ago

Oh, I see! I suspected that it was some kind of mismatch/incompatibility since the same line was in multiple places.

I am currently running: 

$ espflash -V
espflash 2.0.0-rc.3

The reason for running 2.0.0-rc.3 is that I couldn't get 1.7.0 to work. Didn't spend time digging into why, tried a newer version to see if it fixed the problem and it did. But the args had changed.

Perhaps this is not an issue then if one is assumed to use a major version < 2. But it could be nice to add some check on major version and depending on if it is 1 or greater than 1 and call the appropriate command line?

Updated the PR with an option to select between the old v1.x.x and the new v2.x.x argument style manually.

ivmarkov commented 1 year ago

How about a simpler approach: let's just sit on this for a while until espflash V2 is released, and then just apply your first, unconditional version of the patch?

Will just merge your fix, does not hurt. We'll swap it once espflash V2 is released.