esp-rs / esp-idf-template

A "Hello, world!" template of a Rust binary crate for the ESP-IDF framework.
404 stars 49 forks source link

Default to v4.4 #9

Closed MabezDev closed 2 years ago

MabezDev commented 2 years ago

v4.4 is now officially released. v4.4 has most (all?) the patches we need from the Rust side, including realpath so we can now remove panic_immediate_abort feature.

ivmarkov commented 2 years ago

Shall we wait on that a bit until PlatformIO picks up 4.4 as well?

The good news is that this seemingly got merged in 4.4 as well, which means that native bulid on Windows should no longer have the "too long linker commandline" problem. Let me try that...

MabezDev commented 2 years ago

Shall we wait on that a bit until PlatformIO picks up 4.4 as well?

Good idea! Better to be in-sync across all our approaches.

ivmarkov commented 2 years ago

The good news is that this seemingly got merged in 4.4 as well, which means that native bulid on Windows should no longer have the "too long linker commandline" problem. Let me try that...

Yes! Confirmed! Native build finally works on Windows! Such nice...

MabezDev commented 2 years ago

Updated this to support the recent change to native build by default. CI is failing because rustfmt is broken in nightly.