search

esp-rs / esp-idf-template

A "Hello, world!" template of a Rust binary crate for the ESP-IDF framework.
373 stars 44 forks source link

Add `v5.0` choice for esp-idf version #91

Closed SergioGasquez closed 1 year ago

SergioGasquez commented 1 year ago

The v5.0 option should follow release/v5.0 branch as we do with v4.4

Vollbrecht commented 1 year ago

should this be added, or add and remove the oldstable v4.3.2 ?

Vollbrecht commented 1 year ago

in that light what do you think of releasing versions of the cargo-generate files? This can justify an remove of oldstable v4.3.2 ( as with gitpod support) . People than just can use the old git release of it ? Just an idea

MabezDev commented 1 year ago

In the last community meeting, I mentioned that 4.3.x is still supported until December this year, and I didn't see any point in removing it. I've had a slight perspective change since then and am thinking it might be a good idea to remove it as 4.3.x is not recommended for new projects, and this template is all about new projects.

SergioGasquez commented 1 year ago

in that light what do you think of releasing versions of the cargo-generate files? This can justify an remove of oldstable v4.3.2 ( as with gitpod support) . People than just can use the old git release of it ? Just an idea

I don't think many people would use it, but it does not hurt, so I don't really mind

SergioGasquez commented 1 year ago

Also, I added v5.0 choice in the branch that Im working, and CI build is failing due to https://github.com/esp-rs/esp-idf-svc/issues/196, which was solved in https://github.com/esp-rs/esp-idf-svc/pull/200 but has not been released yet, hence if we point to the git repo it works, but atm we are using the latest release (0.45.0)