esp-rs / esp-mbedtls

mbedtls for ESP32 bare-metal
Apache License 2.0
17 stars 7 forks source link

Update to esp-hal 0.19 #35

Closed GnomedDev closed 1 month ago

GnomedDev commented 1 month ago

Compiles on my project, but needs testing by someone who has a project that actually works right now.

AnthonyGrondin commented 1 month ago

You can test that all examples build, using just, and you can also run the examples in examples/ to test at runtime.

Ex: SSID=<SSID> PASSWORD=<PASS> cargo +esp esp32s3 --release --example sync_server --features="esp-wifi/wifi-logs"

Currently esp-wifi doesn't compile with the feature embedded-svc enabled:

error[E0063]: missing fields `pmf_cfg` and `scan_method` in initializer of `embedded_svc::wifi::ClientConfiguration`
    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/esp-wifi-0.7.0/src/wifi/mod.rs:2751:21
     |
2751 |                     embedded_svc::wifi::ClientConfiguration {
     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `pmf_cfg` and `scan_method`

error[E0063]: missing fields `pmf_cfg` and `scan_method` in initializer of `embedded_svc::wifi::ClientConfiguration`
    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/esp-wifi-0.7.0/src/wifi/mod.rs:2778:21
     |
2778 |                     embedded_svc::wifi::ClientConfiguration {
     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `pmf_cfg` and `scan_method`

For more information about this error, try `rustc --explain E0063`.
error: could not compile `esp-wifi` (lib) due to 2 previous errors

This is due to the breaking change in: https://github.com/esp-rs/embedded-svc/pull/75

GnomedDev commented 1 month ago

Got it, I've opened an issue on the esp-hal repo for that build failure. This is blocked on that for now.

bjoernQ commented 1 month ago

The good thing is that embedded-svc is totally optional - we have an inherent version of the wifi API - you would just need to adjust the imports

GnomedDev commented 1 month ago

CI is passing, now that https://github.com/esp-rs/esp-hal/issues/1817 is fixed.