search

esp-rs / esp-pacs

Peripheral Access Crates for Espressif SoCs and modules
Apache License 2.0
103 stars 29 forks source link

snake case for peripheral sigletones #231

Closed burrbull closed 4 months ago

burrbull commented 4 months ago

Do not change case of enum names and values, autoderive fields instead of enums (on common enum rule).

MabezDev commented 4 months ago

I'm not a fan of this change, do you have any rationale or precedence for the change?

burrbull commented 4 months ago

I'm not a fan of this change, do you have any rationale or precedence for the change?

Peripherals? Except making it closer to esp-idf and rustic, no nothing valuable.

MabezDev commented 4 months ago

Thank you for bringing this up, but I think we should keep the peripherals as screaming snake case. We don't use the pac peripherals in esp-hal publically anyways, so this change would only require us to change internal esp-hal code.

Closing.