search

esp-rs / esp-pacs

Peripheral Access Crates for Espressif SoCs and modules
Apache License 2.0
103 stars 29 forks source link

form with prettyplease before cargo fmt #246

Closed burrbull closed 3 months ago

burrbull commented 4 months ago

Update form uses prettyplease formatter on each module (parsed with form) before run cargo fmt So now docs are "normalized" without using nightly rust. cargo fmt could be disabled in future for speed

Also updates svd2rust with Debug implementation cleanups.

cc @jessebraham @MabezDev Please, review.

burrbull commented 4 months ago

I settled on alternative option for now: form with prettyplease and then rustfmt. As it is less breaking.

burrbull commented 3 months ago

cc @jessebraham regenerated

MabezDev commented 3 months ago

Hmm, this seems to break things. I see a few examples of the docs being correct, but with this PR they start with /**.

Imo this probably isn't worth changing, we're in no rush when we build in CI. If you'd like to use this workflow locally for a speed improvement though, please feel free :).