search

esp-rs / esp-pacs

Peripheral Access Crates for Espressif SoCs and modules
Apache License 2.0
115 stars 35 forks source link

Strip `SARADC_` prefix in `APB_SARADC/CTRL` registers #258

Closed playfulFence closed 3 months ago

playfulFence commented 5 months ago

An inconsistency between a register name and a function name, generated after svd2rust in multiple registers was noticed.

jessebraham commented 5 months ago

Thanks, would you mind regenerating the PACs and committing the changes to the source files please?

jessebraham commented 4 months ago

Please do not modify the SVDs directly, all changes should be done via patches. README.md describes the process.

playfulFence commented 4 months ago

Just for log: It came down to a bit of a misunderstanding between me and Jesse, which made me think we wanted to exceptionally commit new SVD changes now.

Except of this, there're no changes to the source files, caused by these patches. The whole PR is about svd2rust clipping some prefixes in registers I've worked with. So it turned out that in a huge commit I repeatedly used names from SVD, when in fact the names of register access functions were clipped (without those prefixes), which was confusing.

burrbull commented 4 months ago

he said you to regenerate pacs (rust files). base.svd should stay unchanged

playfulFence commented 4 months ago

he said you to regenerate pacs (rust files). base.svd should stay unchanged

There was some conversation outside of this PR comments that led to a misunderstanding, the details of which I consider unnecessary to write here