search

esp-rs / esp-pacs

Peripheral Access Crates for Espressif SoCs and modules
Apache License 2.0
103 stars 29 forks source link

ESP32S3: Make an array out of touch_pad #273

Closed playfulFence closed 3 weeks ago

playfulFence commented 3 weeks ago

Related to: https://github.com/esp-rs/esp-hal/issues/1905

playfulFence commented 3 weeks ago

@jessebraham It turned out that on ESP32 the layout of fields in registers TOUCH_PAD8 and TOUCH_PAD9 differs from the layout in TOUCH_PAD0-7. Thus, the changes for esp32 become irrelevant and I don't see a reasonable way how to merge them. The changes in this PR now only apply to esp32s3.

Thanks for your review, by the way! Thanks to it, I've been poking around to see why it doesn't work to use _array for esp32, which is why I found the difference in field layouts