Fix GPIO input configuration

esp-rs / esp32-hal

A hardware abstraction layer for the esp32 written in Rust.

Apache License 2.0

192 stars 28 forks source link

Fix GPIO input configuration #20

Closed sapir closed 4 years ago

sapir commented 4 years ago

Most importantly, the output enable bit should be cleared rather than set.
The output selector should be configured to use the output enable bit.
The input selector is also configured.

MabezDev commented 4 years ago

LGTM thanks! Closes #19 right?

sapir commented 4 years ago

Actually, I think #19 is due to configuration only being performed in the into_whatever methods, so if you use the object directly, it's not configured yet.