search

esp-rs / esp32

Peripheral access crate for the ESP32
Apache License 2.0
127 stars 12 forks source link

Remove prefixes/suffixes from register names #7

Closed jessebraham closed 4 years ago

jessebraham commented 4 years ago

Closes #4, closes #6.

Unfortunately this is blocked until stm32-rs/svdtools#2 is merged as I had to add support for _strip_end to remove _REG, so the Travis build will fail with the current svdtools release. I stand corrected

MabezDev commented 4 years ago

Brilliant! Thanks for this. I would like to wait for the svdtools patch to merge if possible, so would you mind pinging me when that has merged?

jessebraham commented 4 years ago

Sounds good to me, will let you know when it's merged

jeandudey commented 4 years ago

The PR hasn't been merged, perhaps we could add the svdtools script to this repo in the meantime? And when the original svdtools gets updated switch to that instead to avoid fragmentation.

jessebraham commented 4 years ago

I bumped the other PR, see if we can get a response. Worst case we could maintain our own fork of svdtools for the time being, and revert to the original when/if things get merged upstream.

jeandudey commented 4 years ago

It's there now. :tada:

jeandudey commented 4 years ago

@jessebraham In the commit 2dc39ea, shouldn't the esp32.svd file be left untouched?

jessebraham commented 4 years ago

Possibly, wasn't sure what the procedure was for that. I could have sworn I read somewhere to replace the original but of course now I can't find anything to that effect :wink:

I can revert the changes to that file and add the patched version if that's what is desired.

MabezDev commented 4 years ago

@jeandudey correct, but I'll merge this as is and make the changes & note for future contributions. Thank you @jessebraham this will greatly improve the generated API!