The ESP32-C2/H2 do not support 40MHz flash frequency, which is the default, resulting in poor UX

esp-rs / espflash

Serial flasher utility for Espressif SoCs and modules based on esptool.py

Apache License 2.0

488 stars 118 forks source link

The ESP32-C2/H2 do not support 40MHz flash frequency, which is the default, resulting in poor UX #380

Closed jessebraham closed 1 year ago

jessebraham commented 1 year ago

Some potential solutions were suggested in #375:

Override in main (not so beautiful, but really simple)

Make default method, that accepts Chip (kinda duplicate functionality with Default trait, might be confusing)

Add flash frequency to Esp32Params struct (IMHO this looks the best, but this is too complex for this PR, it might be that size should also be moved)

SergioGasquez commented 1 year ago

Same happens for ESP32-H2, 40MHz is not a supported flash frequency

farbodpm commented 1 year ago

May be I can help? Any body can guide me to do this enhancement ?

SergioGasquez commented 1 year ago

May be I can help? Any body can guide me to do this enhancement ?

Hi! I started working on this late last Friday and forgot to assign it to me, sorry. I've just created #389 implementing the third suggested solution, feel free to have a look at it and suggest any feedback and, thanks for your help!