search

esp-rs / espflash

Serial flasher utility for Espressif SoCs and modules based on esptool.py
Apache License 2.0
471 stars 115 forks source link

Updated ESP32-C6 valid targets #402

Closed Nassiel closed 1 year ago

Nassiel commented 1 year ago

Removed incompatible targets of ESP32-C6 and added only IMAC ones Updated to RC5

seanaye commented 1 year ago

I installed this branch locally but I'm unable to successfully flash. I copied the target config riscv32imac-esp-espidf.json to the root and run 

cargo -Z unstable-options  espflash flash --release --monitor --target riscv32imac-esp-espidf
[2023-05-16T21:54:58Z INFO ] Detected 8 serial ports
[2023-05-16T21:54:58Z INFO ] Ports which match a known common dev board are highlighted
[2023-05-16T21:54:58Z INFO ] Please select a port
[2023-05-16T21:55:00Z INFO ] Serial port: '/dev/cu.usbserial-110'
[2023-05-16T21:55:00Z INFO ] Connecting...
[2023-05-16T21:55:01Z INFO ] Using flash stub
   Compiling core v0.0.0 (/Users/seanaye/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core)
   Compiling regex-syntax v0.7.1
   Compiling quote v1.0.27
   Compiling libc v0.2.144
   Compiling memchr v2.5.0
   Compiling log v0.4.17
   Compiling syn v1.0.109
   Compiling glob v0.3.1
   Compiling io-lifetimes v1.0.10
   Compiling lazy_static v1.4.0
error: could not compile `core` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
error: Error loading target specification: Could not find specification for target "riscv32imac-esp-espidf". Run `rustc --print target-list` for a list of built-in targets
MabezDev commented 1 year ago

I installed this branch locally but I'm unable to successfully flash. I copied the target config riscv32imac-esp-espidf.json to the root and run

cargo -Z unstable-options  espflash flash --release --monitor --target riscv32imac-esp-espidf
[2023-05-16T21:54:58Z INFO ] Detected 8 serial ports
[2023-05-16T21:54:58Z INFO ] Ports which match a known common dev board are highlighted
[2023-05-16T21:54:58Z INFO ] Please select a port
[2023-05-16T21:55:00Z INFO ] Serial port: '/dev/cu.usbserial-110'
[2023-05-16T21:55:00Z INFO ] Connecting...
[2023-05-16T21:55:01Z INFO ] Using flash stub
   Compiling core v0.0.0 (/Users/seanaye/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core)
   Compiling regex-syntax v0.7.1
   Compiling quote v1.0.27
   Compiling libc v0.2.144
   Compiling memchr v2.5.0
   Compiling log v0.4.17
   Compiling syn v1.0.109
   Compiling glob v0.3.1
   Compiling io-lifetimes v1.0.10
   Compiling lazy_static v1.4.0
error: could not compile `core` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
error: Error loading target specification: Could not find specification for target "riscv32imac-esp-espidf". Run `rustc --print target-list` for a list of built-in targets

Yeah this is the downside of it being an error when the target mismatches (see here: https://github.com/esp-rs/espflash/pull/402#discussion_r1191148122) I often run custom targets via json files and always run into this. The work around is to use espflash via cargo run instead of cargo espflash e.g: https://github.com/esp-rs/esp-hal/blob/ffe167e64c157199fa37eb10a1097b7c52b85839/esp32c6-hal/.cargo/config.toml#L2

jessebraham commented 1 year ago

Since the requested changes have not yet been made and I'm making a push to get a release out, I've opened #424 which supersedes this PR. Thanks for you contribution regardless, though!

Nassiel commented 1 year ago

Since the requested changes have not yet been made and I'm making a push to get a release out, I've opened #424 which supersedes this PR. Thanks for you contribution regardless, though!

You're welcome, but sorry to ask, what changes where requested? Formating was done and I'm not aware of any other ones.

In the end now it doesn't matter anymore but I'd like to know for the next time :)

Anyhow, sorry that I didn't make them and you have to do it again!

jessebraham commented 1 year ago

The ESP32-C6 was updated but the ESP32-H2 never was. Sorry, I guess I wasn't very clear about that in hindsight. No big deal, I'm just impatient 😁

Nassiel commented 1 year ago

The ESP32-C6 was updated but the ESP32-H2 never was. Sorry, I guess I wasn't very clear about that in hindsight. No big deal, I'm just impatient 😁

Fair enough! Truth being told, I didn't understand I should add that and on the other hand, I wasn't capable to test it. I don't have an H2 in my hands (yet) so it's ok.

Thanks @jessebraham !