search

esp-rs / espflash

Serial flasher utility for Espressif SoCs and modules based on esptool.py
Apache License 2.0
471 stars 115 forks source link

Evaluate merging CI files #438

Closed SergioGasquez closed 11 months ago

jessebraham commented 1 year ago

Thanks for looking into this! At first glance I think this actually looks quite good. I was expecting ci.yml to be messier than it is, so that's great.

I will do a proper review when I get a chance but I expect it's likely fine as-is.

jnross commented 1 year ago

I like the idea of this one. I was recently bouncing between the two CI workflows while debugging a CI issue and wondering why they were split.

jessebraham commented 12 months ago

Sorry it's been awhile 😅 I think this looks fine, if you wouldn't mind updating it (our workflow has changed since this PR was opened, so we need to be careful to reflect those changes) then I think we can merge this.

Please just convert this from a draft and request a review when you're ready!

SergioGasquez commented 11 months ago

Closed in favor of #470