search

esp-rs / espflash

Serial flasher utility for Espressif SoCs and modules based on esptool.py
Apache License 2.0
478 stars 117 forks source link

Please don't automatically vendor OpenSSL #451

Closed faern closed 1 year ago

faern commented 1 year ago

I tried to install cargo-espflash and got compilation errors for OpenSSL (I did not have Perl installed). My system has a perfectly valid OpenSSL installation it can use.

I finally got it to install with OPENSSL_NO_VENDOR=1 cargo install cargo-espflash. But I don't think that should be needed to set explicitly. IMHO using the local install should be the default, and vendoring should be the fallback.

https://github.com/esp-rs/espflash/blob/4e7c018954cef041cedc110c3aebb3e91cd15dde/cargo-espflash/Cargo.toml#L40

SergioGasquez commented 1 year ago

We decided to vendor openSSL since not vendoring it also caused issues for some users. I just created #452 adding some documentation in the README to clarify this and make it easy for user that want to opt out of the default vendored openSSL

faern commented 1 year ago

Thanks for the extra documentation :+1: