search

esp-rs / espflash

Serial flasher utility for Espressif SoCs and modules based on esptool.py
Apache License 2.0
457 stars 111 forks source link

Add `--target-app-partition` argument to flash command #461

Closed jnross closed 8 months ago

jnross commented 11 months ago

Whoops, I didn't mean to close this. I landed the change in our fork, but shouldn't have deleted the branch.

jnross commented 11 months ago

I rebased this on top of #465 to get the CI fixes. That should land before this one.

jnross commented 10 months ago

@SergioGasquez: It's easy to move the argument changes out as you requested. But there are changes to pub function in cli/mod.rs, flasher/mod.rs, and idf_bootloader.rs. I can't see how to avoid those changes and implement this feature without duplicating a large amount of code. Does that mean this change will need to wait until the SemVer major can be bumped to 3? Or is there an additive non-breaking way to add these changes that I'm not seeing?

SergioGasquez commented 10 months ago

@SergioGasquez: It's easy to move the argument changes out as you requested. But there are changes to pub function in cli/mod.rs, flasher/mod.rs, and idf_bootloader.rs. I can't see how to avoid those changes and implement this feature without duplicating a large amount of code. Does that mean this change will need to wait until the SemVer major can be bumped to 3? Or is there an additive non-breaking way to add these changes that I'm not seeing?

I don't think it's worth to duplicate such large amount of code, I'll mark it as v3 and we can implement it once we work for such version

SergioGasquez commented 8 months ago

Hi! We've just started working towards version 3.0, do you mind rebasing your changes so we can merge them?

jnross commented 8 months ago

Yes, will do.

jnross commented 8 months ago

LGTM! Do you mind updating the CHANGELOG.md?

Done!