search

esp-rs / espflash

Serial flasher utility for Espressif SoCs and modules based on esptool.py
Apache License 2.0
478 stars 117 forks source link

CLI argument structs are not marked `#[non_exhaustive]` #473

Closed jessebraham closed 9 months ago

jessebraham commented 1 year ago

This was an incredibly unfortunately oversight which was resulted in us needing to duplicate pretty much any new options between cargo-espflash and espflash. Fixing this is a semver-incompatible change so this will need to happen as part of the v3 release, whenever that happens.

Perhaps another option would be to simply not provide semver guarantees for anything in the cli module (it is feature gated after all, and is only really useful for the binary application).

### Tasks
- [ ] `cli` module should warn that it does not provide semver guarantees
SergioGasquez commented 11 months ago

Perhaps another option would be to simply not provide semver guarantees for anything in the cli module (it is feature gated after all, and is only really useful for the binary application).

As we discussed, we should probably go for this, hence it needs to be documented