Use `esp-flasher-stub` stubs

esp-rs / espflash

Serial flasher utility for Espressif SoCs and modules based on esptool.py

Apache License 2.0

478 stars 117 forks source link

Use `esp-flasher-stub` stubs #518

Closed SergioGasquez closed 10 months ago

SergioGasquez commented 10 months ago

Replace the current C stubs for esp-flasher-stub generated stubs.
- esp-flasher-stub does not generate ESP8266 stubs so I kept the C based stub for it

MabezDev commented 10 months ago

Given how untested the stubs are, this has the potential to induce a bunch of bug reports. Do we want to add them behind a flag first?

SergioGasquez commented 10 months ago

Given how untested the stubs are, this has the potential to induce a bunch of bug reports. Do we want to add them behind a flag first?

I initially did that, but as Jesse suggested, not sure how many people will test it if it's behind a feature. Happy to revert the lats commit and keep it behind a flag, though.

MabezDev commented 10 months ago

I initially did that, but as Jesse suggested, not sure how many people will test it if it's behind a feature

True, presumably there will be a rc release for espflash 3.0, so I guess if many people run into issues with the rc we can revisit the decision.