Closed SergioGasquez closed 5 months ago
/.config/espflash.toml
What's the rationale around having it inside <current_dir>/.config
, instead of <current_dir>
? It doesn't matter much to me, but I just wonder if there is a particular reason. Most other tools with configs, namely probe-rs (cargo embed) place there configuration files in the root of the project.
What's the rationale around having it inside
<current_dir>/.config
, instead of<current_dir>
? It doesn't matter much to me, but I just wonder if there is a particular reason. Most other tools with configs, namely probe-rs (cargo embed) place there configuration files in the root of the project.
Tbh, I just followed the suggestion in https://github.com/esp-rs/espflash/issues/469, I can update the path to be <current_dir>
imo it should probably be in the current directory, but I'll let @jessebraham @bjoernQ and @JurajSadel weigh in too.
imo it should probably be in the current directory, but I'll let @jessebraham @bjoernQ and @JurajSadel weigh in too.
Awesome, let's hear their opinion, I am happy to change it with whatever we decide
I think I would prefer the current directory
Sorry if I've missed something, why was the Cargo package metadata loading in cargo-espflash
crippled? What's the point of even having it in its current rendition?
Sorry if I've missed something, why was the Cargo package metadata loading in
cargo-espflash
crippled? What's the point of even having it in its current rendition?
I'd say we can remove the Cargo metadata, as it is now in the config file and its the same for espflash/cargo-espflash
That's disappointing, I use it in most of my projects :/ Guess I will switch over, thanks.
That's disappointing, I use it in most of my projects :/ Guess I will switch over, thanks.
I mean, we can keep it. No hard opinion there, but then we would have multiple ways of defining those configs.
I updated the local config to live under <current_dir>/espflash.toml
, removed the format
param from cargo metadata for cargo-espflash
and udpated the docs
Checks for config file in:
.cargo/config.toml
as its present in most(or all) our project.Supports the following configurations:
ESPFLASH_PORT
it will be used instead of the config file valueESPFLASH_BAUD
it will be used instead of the config file value[cargo-espflash]: We no longer support setting bootloader, format and partition table in cargo metadata