search

esp-rs / espflash

Serial flasher utility for Espressif SoCs and modules based on esptool.py
Apache License 2.0
478 stars 116 forks source link

Turn off some dependencies for library users #599

Closed bugadani closed 7 months ago

bugadani commented 7 months ago

In this PR I hide some code behind the serialport feature. The code was otherwise available, but not really useful without the feature. Additionally, I'm making certain dependencies optional that were only used with either cli or serialport only. Lastly, I'm moving some code (chiefly ProgressCallbacks [defined together with FlashTarget] and checksum [only used in one place]) to new locations where I believe they better belong.

bugadani commented 7 months ago

I'm going to assume that the apple error (error: failed to run custom build command for openssl-sys v0.9.101) is not my fault :)

SergioGasquez commented 7 months ago

I'm going to assume that the apple error (error: failed to run custom build command for openssl-sys v0.9.101) is not my fault :)

Feel free to ignore it, see https://github.com/esp-rs/espflash/issues/597, it should now be fixed though. Thanks for the PR, will review it on Monday!

NobodyXu commented 7 months ago

cc 1.0.88 should fix this for make < 4.3