search

esp-rs / espflash

Serial flasher utility for Espressif SoCs and modules based on esptool.py
Apache License 2.0
455 stars 110 forks source link

Support loading flash settings from the config file #627

Closed simpkins closed 2 months ago

simpkins commented 2 months ago

This supports loading the flash size, frequency, and mode from the config file.

simpkins commented 2 months ago

I've updated espflash/README.md with some brief documentation of the [flash] section.

Also, have you conducted any testing?

I've been using it for my own development, and I have confirmed that the image header that is written contains the correct flash mode, size, and speed settings taken from the config file. I've also confirmed that passing in flash mode CLI arguments takes precedence over values stored in the config file.

SergioGasquez commented 2 months ago

I've updated espflash/README.md with some brief documentation of the [flash] section.

I think the changes are not pushed, also, mind also updating the cargo-espflash readme?

Thanks a lot! This is a very nice addition.

simpkins commented 2 months ago

I think the changes are not pushed, also, mind also updating the cargo-espflash readme?

Whoops you're right, my local repo had the wrong tracking branch so the push didn't update this branch. I've updated the cargo-espflash readme too, and pushed to the right branch this time.