search

esp-rs / espup

Tool for installing and maintaining Espressif Rust ecosystem.
Apache License 2.0
219 stars 24 forks source link

Windows: ZIP artifacts should be downloaded to IDF_TOOLS_PATH/dist #268

Open georgik opened 1 year ago

georgik commented 1 year ago

Bug description

espup install downloads ZIP diles to location under rustup.

Downloading file 'C:\Users\georgik\.rustup\toolchains\esp\riscv32-esp-elf\esp-12.2.0_20230208/riscv32-esp-elf.zip' from 'https://github.com/espressif/crosstool-NG/releases/download/esp-12.2.0_20230208/riscv32-esp-elf-12.2.0_20230208-x86_64-w64-mingw32.zip'

Prefered location should be %IDF_TOOLS_PATH%/dist. This way idf-installer and esp-idf tools can pick up the already downloaded archive.

SergioGasquez commented 1 year ago

Bug description

espup install downloads ZIP diles to location under rustup.

Downloading file 'C:\Users\georgik\.rustup\toolchains\esp\riscv32-esp-elf\esp-12.2.0_20230208/riscv32-esp-elf.zip' from 'https://github.com/espressif/crosstool-NG/releases/download/esp-12.2.0_20230208/riscv32-esp-elf-12.2.0_20230208-x86_64-w64-mingw32.zip'

Prefered location should be %IDF_TOOLS_PATH%/dist. This way idf-installer and esp-idf tools can pick up the already downloaded archive.

This was decided in https://github.com/esp-rs/espup/discussions/154, we don't assume that the user has any IDF installed and all the installation takes place under $HOME/.rustup/toolchains/<name>

SergioGasquez commented 1 year ago

The point of this issue is to reuse what ESP-IDF has already installed if the user has IDF_TOOLS_PATH defined.