esp-rs / espup

Tool for installing and maintaining Espressif Rust ecosystem.
Apache License 2.0
224 stars 23 forks source link

espup is not able to update using just different build version #300

Closed georgik closed 1 year ago

georgik commented 1 year ago

Perform installation: espup install --toolchain-version 1.71.0.0

Perform update: espup install --toolchain-version 1.71.0.1

Incorrect result: Previous installation of Xtensa Rust 1.71.0 exists in: '/Users/georgik/.rustup/toolchains/esp'. Reusing this installation.

Expected result: espup updates the toolchain to 1.71.0.1

Workaround:

espup uninstall
espup install --toolchain-version 1.71.0.1
SergioGasquez commented 1 year ago

Which version of espup are you using? Tried reproducing the issue on main and couldn't reproduce it:

$ cargo install --git https://github.com/esp-rs/espup espup
$ espup install --toolchain-version 1.71.0.0
$ rustc +esp --version --verbose
rustc 1.71.0-nightly (916fb86be 2023-07-11) (1.71.0.0)
$ espup install --toolchain-version 1.71.0.1
[2023-07-25T13:13:04Z INFO ] 🔧  Uninstalling Xtensa Rust toolchain
[2023-07-25T13:13:04Z INFO ] 🔧  Installing Xtensa Rust 1.71.0.1 toolchain
...
$ rustc +esp --version --verbose
rustc 1.71.0-nightly (4ca000ac8 2023-07-13) (1.71.0.1)
SergioGasquez commented 1 year ago

I was able to reproduce it with last released version, just checked and the PR is merged (https://github.com/esp-rs/espup/pull/272) but not yet released, I will do a release once https://github.com/esp-rs/espup/pull/285 is merged