search

esp8266 / Arduino

ESP8266 core for Arduino
GNU Lesser General Public License v2.1
16.08k stars 13.33k forks source link

WiFi wl_enc_type enum update #9116

Open JAndrassy opened 7 months ago

JAndrassy commented 7 months ago

the wl_enc_type enum is from the first Arduino WiFi library and is part of the Arduino WiFi API. It is updated in newer WiFi libraries by Arduino.

mcspr commented 7 months ago

Not upstream everywhere, yet https://github.com/arduino/ArduinoCore-renesas/blob/3dd08de860915a3577c232d3c0c2a66d33e04df7/libraries/WiFiS3/src/WiFiTypes.h#L20-L32 UNO R4 deployed these

Still pending for older cores https://github.com/arduino-libraries/WiFi101/pull/350 https://github.com/arduino-libraries/WiFiNINA/pull/259

I would guess this should be ok here, actively saving from undefined enum errors and architecture ifdefs

JAndrassy commented 7 months ago

the other WiFi library in the Renesas Core has the enum here https://github.com/arduino/ArduinoCore-renesas/blob/3dd08de860915a3577c232d3c0c2a66d33e04df7/libraries/lwIpWrapper/src/CNetIf.h#L73

in Arduino's Mbed Core my PR with this was already merged. https://github.com/arduino/ArduinoCore-mbed/pull/776