Closed ayushsharma82 closed 5 months ago
@me-no-dev , Please review this as well.
@me-no-dev , Please review this as well.
Not an Espressif repo (maybe ping @d-a-v). Will merge based on esp32 review, though. Also, please take a look at 'doc/' and WebServer's 'README.md' and make sure everything is up-to-date w/ web documentation related to WebServer
Oh. I thought me-no-dev is a maintainer in this repo too.
I'll check documentation.
Oh. I thought me-no-dev is a maintainer in this repo too.
Long time ago :)
@mcspr , @d-a-v,
ESP32 PRs are merged therefore this PR is ready for review & merger as well.
Any idea why LwIP CI tests are failing? Compiling on Arduino IDE locally doesn't show any error.
Multiple libraries were found for "WiFi.h" Used: /home/runner/work/_temp/arduino_ide/libraries/WiFi Not used: /home/runner/Arduino/hardware/esp8266com/esp8266/libraries/ESP8266WiFi
Great! Everything compiles now, what should we do about style test?
This PR implements filters and removable routes in ESP8266 arduino core, making it API compatible with recent changes to ESP32 WebServer API.
Reference (Recent additions to ESP32 WebServer API):
Noteable Changes:
setFilter
)removeRoute
,removeHandler
,_removeRequestHandler
)