esp8266 / Arduino

ESP8266 core for Arduino
GNU Lesser General Public License v2.1
16.08k stars 13.33k forks source link

Implemented support for filters and removable routes in ESP8266WebServer #9152

Closed ayushsharma82 closed 5 months ago

ayushsharma82 commented 5 months ago

This PR implements filters and removable routes in ESP8266 arduino core, making it API compatible with recent changes to ESP32 WebServer API.

Reference (Recent additions to ESP32 WebServer API):

Noteable Changes:

  1. Request Filters (setFilter)
  2. Removable Routes (removeRoute, removeHandler, _removeRequestHandler)
ayushsharma82 commented 5 months ago

@me-no-dev , Please review this as well.

mcspr commented 5 months ago

@me-no-dev , Please review this as well.

Not an Espressif repo (maybe ping @d-a-v). Will merge based on esp32 review, though. Also, please take a look at 'doc/' and WebServer's 'README.md' and make sure everything is up-to-date w/ web documentation related to WebServer

ayushsharma82 commented 5 months ago

Oh. I thought me-no-dev is a maintainer in this repo too.

I'll check documentation.

me-no-dev commented 5 months ago

Oh. I thought me-no-dev is a maintainer in this repo too.

Long time ago :)

ayushsharma82 commented 5 months ago

@mcspr , @d-a-v,

ESP32 PRs are merged therefore this PR is ready for review & merger as well.

ayushsharma82 commented 5 months ago

Any idea why LwIP CI tests are failing? Compiling on Arduino IDE locally doesn't show any error.

mcspr commented 5 months ago

Multiple libraries were found for "WiFi.h" Used: /home/runner/work/_temp/arduino_ide/libraries/WiFi Not used: /home/runner/Arduino/hardware/esp8266com/esp8266/libraries/ESP8266WiFi

ayushsharma82 commented 5 months ago

Great! Everything compiles now, what should we do about style test?