Closed 0x2b3bfa0 closed 8 years ago
4.
The HTML code is ugly. Wouldn't be better to store the html files as files on the spiffs and then replace parts with String.replace?
5.
I kept reading your code and it's like the output of a decompiler :smiling_imp:
6.
Can you document the use of 9 blank lines form line 68 to line 76 on ESP8266Basic.ino?
They seem to have transparent text with a rootkit :smiling_imp:
re: #4, how do you propose getting the data into a formated spiffs file? (it can't be put into the firmware image as far as I can tell)
My point of view (just a different one, not meant to be combative):
The authors coding style is no better or worse that anyone else's. It so happens that it is similar to my own.
I think that the code should be cleaner and also observe these rules: