search

espadrine / aulx

Aulx is an autocompleter for Web code.
http://espadrine.github.com/aulx/
68 stars 8 forks source link

Support YUI compressor. #6

Open grssam opened 11 years ago

grssam commented 11 years ago

It would be really nice if YUI compression worked on aulx.js and aulx-ui.js . Right now, it just gives errors and produces half-compressed code.

espadrine commented 11 years ago

What kind of compression fails? It isn't a linter, right? The JS code is valid JS, right? What kind of errors do we get?

grssam commented 11 years ago

They are all syntax errors. I did not look at them into detail yet. You can try it out at http://refresh-sf.com/yui/ .

espadrine commented 11 years ago

A quick look gives me intuition that YUI compressor fails to parse ES5. It can only parse ES3. Indeed, it seems to forbid the delete keyword as an object literal key. ES5 specifically permits an IdentifierName there, not an Identifier, which would forbid keywords.

grssam commented 11 years ago

Hrmm. Weird . I have minified so much code via YUI and never had an issue. I don;t think that YUI cannot parse ES5. Infact the yui compressor code itself uses delete everywhere in the code : https://github.com/yui/yuicompressor/blob/master/nodejs/index.js

espadrine commented 11 years ago

You misunderstand me. The following is valid ES5 and invalid ES3.

var foo = {
  delete: "something",
  get 0() { return 'zero'; }
};
grssam commented 11 years ago

Ah.. Shall we open an issue in their github repo ?

espadrine commented 11 years ago

You may! Point to this bug if you want.

(I know little of their project goals for YUI compressor; maybe ES5 is simply out of scope for them.)

grssam commented 11 years ago

See the conversation at https://github.com/yui/yuicompressor/issues/98

Basically its because of Rhino,

espadrine commented 11 years ago

I feel like changing the code for a tangential project which acknowledges that it is lacking is wrong. May I consider this issue closed?

grssam commented 11 years ago

How much change in our code are we talking ? If it is simply adding quotes around certain keywords, then why not go ahead and do it ?

PS: come online on IRC man!

espadrine commented 11 years ago

Why not simply use a better minifier, instead of changing the project to fit through a specific incorrect minifier?

PS: I'm just back, I'm getting set up again.