search

espanso / hub-frontend

The official Espanso Hub website
https://hub.espanso.org
MIT License
11 stars 6 forks source link

Add share package button #30

Open arabello opened 2 years ago

arabello commented 2 years ago

The hub already supports URL-based package sharing, but there is no button to easily copy the URL value. It would make sense to change the current homepage (GitHub repo) button with this functionality, while making the package title a clickable link to its homepage.

Additionally, on mobile the button could use the Web Share API.

anmol-fzr commented 4 months ago

Hey, @arabello I Would like to contribute to this issue.

AucaCoyan commented 4 months ago

You can have this too. arabello is not often here, so I can cover him up. Ask me anything you need! We are also in the espanso discord https://discord.gg/DFcCNDg7bB

arabello commented 4 months ago

Hi there! I'm glad you wanna contribute! feel free to ask me anything related to the codebase here or on Discord (please tag me so I can be more responsive).

Enjoy!

anmol-fzr commented 4 months ago

@arabello So, on what page / component are we planning to add a share button ?

arabello commented 4 months ago

@anmol-fzr I think the issue was already solved, but it wasn't closed. I am sorry for the misleading. It was an old self-reminder. The current package page has a share button with a pop-up menu to copy the link to the clipboard, see below for an example.

If you are still interested in making a contribution, I think we can improve the feature by removing the pop-menu and directly copy the link to the clipboard. Otherwise, it makes sense to close the issue as-it-is.

Sorry again 🙏

https://github.com/espanso/hub-frontend/assets/16003164/be5507b7-4aa4-4981-a21c-890c8d620c6f