search

espanso / hub

The official Espanso's package repository
MIT License
55 stars 141 forks source link

Update packages: greetings-german and greetings-english #136

Closed katrinleinweber closed 1 week ago

katrinleinweber commented 4 weeks ago

Since the hub-site can has a Source tab, I see no point in keeping the tables and associated dev dependencies.

Also:

smeech commented 4 weeks ago

Minor update to a couple of short, simple trigger/replace packages. No script/shell/cmd or malicious code.

I must admit, I liked the README.md tables - I consider that page in the Hub as a sort of shop-window for the package with a quick and easy way of seeing what it's about, without inspecting the code. I guess it's less important for easily readable packages like yours. I'm not sure that people browsing the packages will stop to run the curl command, and most of us don't have yq installed anyway. I wasn't sure of the relevance of the bit about dependencies, though, so am happy to lose that.

Would you kindly update the package paths and _manifest.yml versions to 0.1.1 or 0.2.0 please?

By the way, you might be interested in the short conversation on Discord on a similar topic

@federico-terzi isn't around much these days, so I wouldn't expect a response from him, I'm afraid.

Thank you for your submission!

katrinleinweber commented 2 weeks ago

@smeech Sure thing, done.

I liked the README.md tables - I consider that page in the Hub as a sort of shop-window for the package …

Agreed. How about a TypeScript-based enhancement of the Source tab so that it would not only display the raw YAML, but actually be rendered below the ReadMe content into a table?

smeech commented 2 weeks ago

Agreed. How about a TypeScript-based enhancement of the Source tab so that it would not only display the raw YAML, but actually be rendered below the ReadMe content into a table?

Is this a suggested enhancement for the Hub, or a plan to reorganise your own README.md? If the latter, it has to be useful to people browsing the Hub, and we have to ensure the Hub registers its content. We have enough difficulty rendering README.md files, so I guess they have to be fairly conventional.

smeech commented 1 week ago

Merged. I'll be interested to see how the Hub copes with deletion of the previous version (which is not recommended, but I think is generally a good idea).