feat: Add `expand-contractions-en` package

espanso / hub

The official Espanso's package repository

MIT License

55 stars 141 forks source link

feat: Add `expand-contractions-en` package #95

Closed lewisblackburn closed 2 months ago

lewisblackburn commented 9 months ago

This expands contractions e.g. aren't → are not .

This is useful for when writing essays, as professional writing often requires a more formal and precise language style, eliminating contractions contributes to a more polished and academic tone.

smeech commented 2 months ago

I presume you're still working on this - just to let you know I am keeping an eye on it.

lewisblackburn commented 2 months ago

I think everything should be ready to go now, I'd be happy make any more changes. I apologise if there are any mistakes as I am still learning how to use GitHub 😅

smeech commented 2 months ago

I've lost track of the _manifest.yml and README.md files and can't see the contents of your package.yml. You may need to copy them from https://github.com/lewisblackburn/espanso-expand-contractions-en to your updated copy of espanso/hub, in a version folder, and submit a fresh PR with the whole set, having removed the espanso-contractions-en Submodule.

Don't worry - I've learned a lot in the last few months!

smeech commented 2 months ago

Thank you - we're getting there!

Would you kindly:

Rename the package folder to expand-contractions-en/0.1.0/ as in your original PR, adding a version subfolder (see the packages already in espanso/hub), as named in _manifest.yml,
Add a homepage: parameter to _manifest.yml even if the value is just something like: https://github.com/lewisblackburn/hub/tree/main/packages/expand-contractions-en (renamed as above), or https://github.com/lewisblackburn/hub
Change the installation instructions in README.md to download from the Hub, i.e. match those in the docs

please?

lewisblackburn commented 2 months ago

Yes of course no worries, I will do that ASAP. Thanks for your patience.

smeech commented 2 months ago

I'm afraid you omitted a period in /0.1.0/ so it's reading /0.10/.

Can you remove the old folder and contents (without the version number), please? While I could delete the files, I might not be able to remove their folder, which may cause problems.

lewisblackburn commented 2 months ago

Oh okay sorry about that, one second

lewisblackburn commented 2 months ago

Should I add the correct folder back?

smeech commented 2 months ago

You may have removed the wrong one. All I can see now in the file-list is the folder and files without the version number.

We'll get there!

smeech commented 2 months ago

We're now back to two folders, both named /espanso-contractions-en/0.1.0/, I'm afraid. We just need one.

smeech commented 2 months ago

The folder needs the package name: expand-contractions-en, as in _manifest.yml. Sorry - I should have spotted that earlier.

lewisblackburn commented 2 months ago

I think that should have fixed it (I hope)

smeech commented 2 months ago

Thank you. I've gone ahead with the merge. The package can be found at https://hub.espanso.org/expand-contractions-en. espanso install expand-contractions-en works.

Well done!