search

espdev / scikit-mpe

Minimal path extraction using the fast marching method
https://scikit-mpe.readthedocs.io
MIT License
17 stars 1 forks source link

travel_time with order==2 has failed #1

Closed espdev closed 3 years ago

espdev commented 4 years ago

Currently, order == 2 for computing travel time in scikit-fmm (v 2019.1.30) has a numerical issue and does not work properly: https://github.com/scikit-fmm/scikit-fmm/issues/28

The following code should be removed after fixing the issue in scikit-fmm: https://github.com/espdev/scikit-mpe/blob/59551bae579a6e19b6e195b57c7f5ba252a065f3/skmpe/_parameters.py#L40-L47

And also in the tests: https://github.com/espdev/scikit-mpe/blob/59551bae579a6e19b6e195b57c7f5ba252a065f3/tests/test_mpe.py#L13

jkfurtney commented 4 years ago

This should be fixed in scikit-fmm master, can you give it a try and let me know if you find any issues? Thanks

espdev commented 4 years ago

@jkfurtney I have checked my code from refactoring-and-docs branch with scikit-fmm from master. It works fine! All tests with order 1 and 2 were completed successfully.

Thank you!