espeed / bulbs

A Python persistence framework for graph databases like Neo4j, OrientDB and Titan.
http://bulbflow.org
Other
622 stars 83 forks source link

Tests fail on python 3.3 #115

Closed frankier closed 10 years ago

frankier commented 10 years ago

Since it's the README says it's supported I assume this is a regression. I would recommend adding python 3 to the tox.ini to stop this happening in future.

$ make test ... /usr/lib/python3.3/site-packages/setuptools/command/test.py:116: UserWarning: Module argparse was already imported from /usr/lib/python3.3/argparse.py, but /home/grimboy/sources/bulbs/argparse-1.1-py3.3.egg is being added to sys.path add_activation_listener(lambda dist: dist.activate()) Traceback (most recent call last): File "setup.py", line 101, in test_suite='main.run_tests' File "/usr/lib/python3.3/distutils/core.py", line 148, in setup dist.run_commands() File "/usr/lib/python3.3/distutils/dist.py", line 929, in run_commands self.run_command(cmd) File "/usr/lib/python3.3/distutils/dist.py", line 948, in run_command cmd_obj.run() File "/usr/lib/python3.3/site-packages/setuptools/command/test.py", line 138, in run self.with_project_on_sys_path(self.run_tests) File "/usr/lib/python3.3/site-packages/setuptools/command/test.py", line 118, in with_project_on_sys_path func() File "/usr/lib/python3.3/site-packages/setuptools/command/test.py", line 164, in run_tests testLoader = cks File "/usr/lib/python3.3/unittest/main.py", line 124, in init self.parseArgs(argv) File "/usr/lib/python3.3/unittest/main.py", line 168, in parseArgs self.createTests() File "/usr/lib/python3.3/unittest/main.py", line 175, in createTests self.module) File "/usr/lib/python3.3/unittest/loader.py", line 137, in loadTestsFromNames suites = [self.loadTestsFromName(name, module) for name in names] File "/usr/lib/python3.3/unittest/loader.py", line 137, in suites = [self.loadTestsFromName(name, module) for name in names] File "/usr/lib/python3.3/unittest/loader.py", line 122, in loadTestsFromName test = obj() File "setup.py", line 52, in run_tests from bulbs_tests import suite File "tests/bulbs_tests.py", line 6, in from bulbs.neo4jserver.tests.bulbs_tests import test_suite as neo4j_bulbs_suite File "/home/grimboy/sources/bulbs/bulbs/neo4jserver/tests/init.py", line 3, in from .bulbs_tests import test_suite as bulbs_test_suite File "/home/grimboy/sources/bulbs/bulbs/neo4jserver/tests/bulbs_tests.py", line 9, in BulbsTestCase.client = Neo4jClient(config) File "/home/grimboy/sources/bulbs/bulbs/neo4jserver/client.py", line 357, in init self.scripts = GroovyScripts(self.config) File "/home/grimboy/sources/bulbs/bulbs/groovy.py", line 73, in init self.update(file_path, self.default_namespace) File "/home/grimboy/sources/bulbs/bulbs/groovy.py", line 119, in update methods = self._get_methods(file_path) File "/home/grimboy/sources/bulbs/bulbs/groovy.py", line 159, in _get_methods return Parser(file_path).get_methods() File "/home/grimboy/sources/bulbs/bulbs/groovy.py", line 254, in init Scanner(handlers).scan(groovy_file) File "/home/grimboy/sources/bulbs/bulbs/groovy.py", line 245, in scan self.get_item(fin,line) File "/home/grimboy/sources/bulbs/bulbs/groovy.py", line 236, in get_item callback(self,content) File "/home/grimboy/sources/bulbs/bulbs/groovy.py", line 270, in add_method sha1 = self._get_sha1(method_definition) File "/home/grimboy/sources/bulbs/bulbs/groovy.py", line 293, in _get_sha1 sha1.update(method_definition) TypeError: Unicode-objects must be encoded before hashing Makefile:17: recipe for target 'test' failed make: *\ [test] Error 1

espeed commented 10 years ago

All tests now passing for Python 3.3, and py33 has been added to tox.ini https://github.com/espeed/bulbs/commit/9f09f1d2ea72ffa137140d8b649f71f6f7486442

Thanks.