search

esperantojs / esperanto

DEPRECATED: An easier way to convert ES6 modules to AMD and CommonJS
http://esperantojs.org
234 stars 21 forks source link

_evilES3SafeReExports: Fix ES3 syntax error for default re-exporting #176

Closed XrXr closed 9 years ago

XrXr commented 9 years ago

Fixes #175

stefanpenner commented 9 years ago

:+1:

XrXr commented 9 years ago

@Rich-Harris could you review this please? We, and I think many others are waiting for this to be merged so It can be fixed in Ember CLI so we can support IE8 on its way out.

stefanpenner commented 9 years ago

@Rich-Harris could you review this? We, and I think many others are waiting for this to be merged so It can be fixed in Ember CLI so we can support IE8 on its way out.

please note, it appears the windows tests are failing. Could you look into this?

XrXr commented 9 years ago

@stefanpenner I looked at the console output from appveyor. nodejs_version=0.10 and nodejs_version=0.12 couldn't connect to Github. The one that has failed tests is nodejs_version=1.0

AFAIK Node.js doesn't have a 1.0 at the moment. Is it IO.js?

XrXr commented 9 years ago

I looked into it a little, I think the failed tests are inherited from master.

https://ci.appveyor.com/project/eventualbuddha/esperanto/build/1.0.181

I ran the console output of the master branch build and the build for this PR through a difftool, and the fail messages are exactly the same.

stefanpenner commented 9 years ago

@eventualbuddha can we move this forward?

stefanpenner commented 9 years ago

I now have commit and publish, so lets get this moving.

It does appear like the appveyor build has never passed. So it should not block this bugfix.

alexlafroscia commented 9 years ago

For people seeing issues with the Ember CLI that this should fix, what would be the right way to get this patch now?

PS: Thanks for pulling this :grinning:

stefanpenner commented 9 years ago

For people seeing issues with the Ember CLI that this should fix, what would be the right way to get this patch now?

tricky, it appears something if wrong with esperantos build preventing me from releasing.

I would suggest just running your prod build output through https://github.com/stefanpenner/es3-safe-recast as a workaround

alexlafroscia commented 9 years ago

Alright, thanks! I'll keep an eye open for an Esperanto update in the near future, too.