search

esperecyan / UniVRMExtensions

https://pokemori.booth.pm/items/1788660
MIT License
45 stars 3 forks source link

Original VRMSpringBone/ColliderGroup components aren't being deleted after conversion to DynamicBone/DynamicBoneCollider #3

Closed andreiagmu closed 2 years ago

andreiagmu commented 2 years ago

I'm not sure if that behavior (keeping the original components after the conversion) is intended, or not. But this seems like a bug, it would make sense to delete the original VRMSpringBone components after conversion to DynamicBone. Also, DynamicBone doesn't work if the original VRMSpringBones are still present on the character at the same time.

esperecyan commented 2 years ago

Thank you for your request. I will consider implementing it.

andreiagmu commented 2 years ago

Thanks! Maybe a new bool (or an enum?) could be added on the wizard, something like "Delete Original Swaying Objects" or "Keep Original Swaying Objects".

esperecyan commented 2 years ago

I implemented this feature in UniVRMExtensions-3.0.0.

andreiagmu commented 2 years ago

The feature worked correctly, thanks for implementing it!

The name of the new bool field became truncated on the Wizard. ("Remove swaying objects f") Having more space on the left to show the name of the fields, or having a tooltip when you hover the mouse over the bool's name, I think would help the user to understand what the feature does. capture_20220129_095211_002

esperecyan commented 2 years ago

Thank you for the report, I fixed in v3.0.1.

andreiagmu commented 2 years ago

Thank you for the report, I fixed in v3.0.1.

Great, thanks for the label fix! :D